fix: update cCOP pool reset frequency #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chainlink often reports prices very close to the 5 minutes mark, we sometimes end up in a situation where the pool no longer has a valid median until the new price is relayed, essentially disabling trading against the pool. Because of this we are increasing the
referenceRateResetFrequencyparameter of the pool to6 minutesso that there's a bit more buffer when relaying the chainlink price. This parameter is used in the oracleHasValidMedian function inside the biPoolManager. This goes together with what we already did during the oracle whitelist proposal where we also increased the report expiry time.Other changes
N/A
Tested
Simulation is still green.
referenceRateResetFrequencyis only used insideshouldUpdateBucketsandoracleHasValidMedianin the biPoolManager, so this change shouldn't have any other impact.